Repository navigation
fix(rtc): deliver media stream events only to their own stream - #910
Merged
Merged
Conversation
swayamg20
requested review from
changt,
cloudwebrtc,
lukasIO and
xianshijing-lk
as code owners
October 28, 2026 14:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#564 added event-type filtering, which fixed the leak in the title, but every
AudioStreamandVideoStreamsubscriber still received every other stream's frame events, so the event-loop work grew with the square of the stream count.AudioSource.capture_framealso subscribed to all FFI events on every frame.AudioStreamandVideoStreamfilters also matchstream_handleagainst the stream's own handle once the create request returns. They still subscribe before creating the stream, so no early frames or EOS are missedcapture_framesubscribes only tocapture_audio_frameevents, narrowed to its ownasync_idonce the request returnsThis uses the same handle filter as
data_track.pyanddata_stream.py, and doesn't touchFfiQueue, so it's independent of #892.Refs #563
Testing
uv run pytest tests/rtc/test_media_ffi_filter.py tests/rtc/test_ffi_queue.py tests/rtc/test_room_ffi_filter.py -q -W erroruv run mypy livekit-rtcuv run ruff check .anduv run ruff format --check .