Repository navigation
Correct the single_peer_connection default in RoomOptions docstring - #917
Merged
Merged
Conversation
When None the field isn't sent, and the FFI keeps the Rust RoomOptions::default(), which is true. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
👋 This PR has no changeset. If it should be released, add a markdown file under ---
"livekit-rtc": patch
---
Short description of the change, used in the release notes.
If this change doesn't need a release (docs, CI, tests), you can ignore this comment. |
GSmithApps
marked this pull request as ready for review
November 2, 2026 21:00
GSmithApps
requested review from
changt,
cloudwebrtc,
lukasIO and
xianshijing-lk
as code owners
November 2, 2026 21:00
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
changt
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docstring said that when
None,single_peer_connectiondefaults to false. In that case the field isn't sent, and the FFI keeps Rust'sRoomOptions::default(), which sets it totrue(rust-sdkslivekit-ffi/src/room_apis/conversion/room.rs,livekit/src/room/mod.rs). Docstring only.🤖 Generated with Claude Code