Skip to content

other_sdks - #1317

Merged
stephen-derosa merged 2 commits into
mainfrom
sderosa/BOT-520-client-info
Aug 10, 2026
Merged

other_sdks#1317
stephen-derosa merged 2 commits into
mainfrom
sderosa/BOT-520-client-info

Conversation

@stephen-derosa

Copy link
Copy Markdown
Contributor

No description provided.

@stephen-derosa
stephen-derosa requested a review from ladvoc as a code owner August 6, 2026 00:07
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Changeset incomplete

This PR's changeset is missing version bumps for packages that are affected by the change. The following packages still require a bump:

  • livekit-common
  • livekit-data-stream
  • livekit-datatrack
  • livekit-protocol
  • livekit-uniffi

Already covered:

  • livekit (minor)
  • livekit-api (minor)
  • livekit-ffi (minor)

A package must be bumped when its own files change, and whenever a package it depends on is bumped (so downstream consumers get a matching release).

Click here to create a changeset for the missing packages

The link pre-populates a changeset file with patch bumps for the missing packages. You can also add them to your existing changeset. Edit the bump types as needed before committing.

If this change doesn't require a version bump, add the internal label to this PR.

devin-ai-integration[bot]

This comment was marked as resolved.

@ladvoc ladvoc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comments are addressed. I think this is a good solution to avoid a breaking C ABI change that would require updating all FFI clients. Let's wait for other reviewers to get eyes on this before merging.

Comment thread livekit-api/src/signal_client/mod.rs Outdated
Comment thread livekit-api/src/signal_client/mod.rs Outdated
@ladvoc
ladvoc requested a review from xianshijing-lk August 6, 2026 04:19
@xianshijing-lk

Copy link
Copy Markdown
Contributor

could you please add some description to this PR to explain what it doe ?

@stephen-derosa
stephen-derosa requested a review from ladvoc August 6, 2026 22:23
@stephen-derosa
stephen-derosa force-pushed the sderosa/BOT-520-client-info branch from a998218 to ed838f1 Compare August 6, 2026 22:33
devin-ai-integration[bot]

This comment was marked as resolved.

Comment thread livekit-api/src/signal_client/mod.rs Outdated
Comment thread .changeset/other_sdks_propagation.md Outdated
@stephen-derosa
stephen-derosa force-pushed the sderosa/BOT-520-client-info branch from ac8f55d to 81eb312 Compare August 7, 2026 16:09
@stephen-derosa
stephen-derosa merged commit 5b14899 into main Aug 10, 2026
2 checks passed
@stephen-derosa
stephen-derosa deleted the sderosa/BOT-520-client-info branch August 10, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants