Conversation
ladvoc
force-pushed
the
ladvoc/request-response
branch
from
September 4, 2026 15:07
d3bb13d to
e0596d8
Compare
ladvoc
marked this pull request as ready for review
September 4, 2026 16:05
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
boks1971
approved these changes
Sep 4, 2026
| } | ||
| } | ||
|
|
||
| func (p *pendingRequest) ID() uint32 { |
Contributor
There was a problem hiding this comment.
:nit: group all the methods of pendingRequest and all method of engine (if it can be moved to engine.go, that would be great too) together. Would be good to avoid interspersed methods.
Also, methods which are not struct methods, move them to the end.
Contributor
Author
ladvoc
force-pushed
the
ladvoc/request-response
branch
2 times, most recently
from
September 14, 2026 21:40
036563a to
618d127
Compare
ladvoc
force-pushed
the
ladvoc/request-response
branch
from
September 22, 2026 16:46
618d127 to
fa264c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds handling for
RequestResponsesignal messages: requests can now carry a request id and wait for their response (or a typed success message) withnewPendingRequest/Await, and responses nobody is waiting on are forwarded to the room, which logs failures. Groundwork for data tracks and other request/response signalling; no public API changes.Closes BOT-541