Data tracks core - #990
Data tracks core#990ladvoc wants to merge 14 commits into
Conversation
f15a229 to
b7b6532
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
b7b6532 to
1c85018
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
5572d61 to
dc69ba0
Compare
| func (d *depacketizer) frameFromSingle(packet dtp.Packet, options depacketizerPushOptions) depacketizerPushResult { | ||
| var result depacketizerPushResult | ||
| if len(d.partials) >= options.maxPartialFrames { | ||
| result.drop = d.evictOldest(packet.FrameNumber) |
There was a problem hiding this comment.
The single frame has not been appended to the partials, do we still need to evict one?
There was a problem hiding this comment.
A Single arriving while the partials map is at capacity is treated as a signal that the oldest in-flight partial is stale: the publisher has moved on to a later frame, and on an unordered channel with no retransmits its missing packets aren't coming. It doesn't change what gets dropped (the next Start would evict it anyway), only that the drop is reported promptly and attributed to the frame that actually superseded it. This matches the Rust implementation.
c9fa55a to
ae3dc6f
Compare
For consistency with other client SDKs.
c2ca3f6 to
5692ffc
Compare
2 participants
Adds core types (e.g., info, frame, schema, etc.) and packetizer/depacketizer.
Areas to review:
Closes BOT-541