Repository navigation
test: a 60 s per-test limit on Windows, and the three tests that timed out split - #61
Merged
Merged
Conversation
Three tests that take 12–17 s on the Windows runners passed the 30 s limit on a 2.5× spike, in two days, and passed on re-run. The limit elsewhere and maxWorkers are unchanged.
One test started six CLI children and three git repositories and passed 30 s on a Windows runner (33.9 s, run 38388376553). The fifteen assertions are the same, five per test.
One test started thirteen CLI children and passed 30 s on a Windows runner (31.8 s, run 38378398875). The same six invocations run twice each, the --forge one once, and each command's snapshot is compared on its own.
One test checked both workspaces and passed 30 s on a Windows runner (31.3 s, run 38323301390). Both are still synced before the extractions; each test then checks one, with the same three assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main), each passing when run again. Measured over 33 Windows jobs: 3 failures in 18node 22jobs, none in 15node 24jobs, none on ubuntu.vitest.config.ts: the per-test limit is 60 s when the platform iswin32and stays 30 s elsewhere.maxWorkers: 6is unchanged.drift-promote› 4. D4 — three cases →4a,4b,4c(15 assertions before, 5 + 5 + 5 after);cli› the three commands write nothing in the workspace or the Forge → one test per command (recipes,ingredients,targets): the same six invocations twice each and the--forgeone once, each command's snapshot compared on its own;golden-param› after both extractions every file of both workspaces is unchanged → one test per workspace, both still synced before the extractions.src/, no version change: this publishes nothing.Known and left as is:
test/cli.test.tshas one older test with an explicit30_000limit, which is now half the Windows default; it was not among the failures. EachrunClichild keeps its own 25 s limit, so a single stuck child still fails fast.Test plan
npm run typecheck,npm run buildnpx vitest run --exclude test/ci.test.ts --maxWorkers=6on Linux — 101 files passed, 1 skipped; 2750 tests passed, 8 skippedwin32arm of the config and the Windows times of the eight new tests can only be seen there