smite-ir: add malformation parameter to funding_created - #235
Draft
NishantBansal2003 wants to merge 2 commits into
Draft
smite-ir: add malformation parameter to funding_created#235NishantBansal2003 wants to merge 2 commits into
NishantBansal2003 wants to merge 2 commits into
Conversation
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #178
Depends-on: #212
Add a malformation parameter to
SendFundingCreatedthat overwrites an allowlisted field offunding_createdbefore sending it to the target. Some fields currently only contain valid values, so this allows the IR to exercise their invalid values as well.Oracle state is updated based on the message actually sent to the target, after applying the malformation. If the malformed signature cannot be decoded, we send only the invalid signature without marking the state as desynced, since the target should simply reject it as an invalid signature rather than behave differently.
The generator produces only non-malformed
funding_createdmessages,OperationParamMutatoradds malformations using repeated bytes, random bytes, or interesting integers matching the field's exact width.