Skip to content

Bump dependencies - #243

Open
morehouse wants to merge 1 commit into
masterfrom
bump_deps
Open

Bump dependencies#243
morehouse wants to merge 1 commit into
masterfrom
bump_deps

Conversation

@morehouse

Copy link
Copy Markdown
Collaborator

Update to the latest stable versions for all dependencies.

chacha20poly1305 v0.11 deprecates Nonce::from_slice, so we use nonce_bytes.into() instead.

Smoke tested by fuzzing LDK with the IR scenario for several hours.

Update to the latest stable versions for all dependencies.

chacha20poly1305 v0.11 deprecates Nonce::from_slice, so we use
nonce_bytes.into() instead.
@NishantBansal2003

Copy link
Copy Markdown
Contributor

I ran cargo upgrade --incompatible, and I see that some dependencies were not fully bumped. For eg: toml = "1.1" and cc = "1.4", Is there any reason for pinning them to their existing or lower versions?

@morehouse

Copy link
Copy Markdown
Collaborator Author

The version in Cargo.toml specifies the minimum requirement in the current major release (or minor release if major is 0). I only updated dependencies in Cargo.toml that had to be updated to get the latest stable versions. toml and cc are still in the 1.x major release series, so there's no need to update them in Cargo.toml. I just ran cargo update and the latest versions were automatically bumped in Cargo.lock:

[[package]]
name = "toml"
version = "1.1.5+spec-1.1.0"
[[package]]
name = "cc"
version = "1.4.5"

I think this is the right approach to bumping dependencies unless there's a specific feature we need from a minor release -- then we would need to pin the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants