smite: refactor commitment transaction construction - #244
Merged
Conversation
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
morehouse
reviewed
Sep 10, 2026
NishantBansal2003
force-pushed
the
refactor-commitment
branch
from
September 11, 2026 08:41
153a40d to
48bc5ac
Compare
erickcestari
approved these changes
Sep 11, 2026
| let local_per_commitment_point = state.party(local_side).per_commitment_point; | ||
|
|
||
| let mut outputs: Vec<TxOut> = Vec::new(); | ||
|
|
Contributor
There was a problem hiding this comment.
nit: Evaluate the dust check once and reuse it for the to_local/to_remote outputs and their anchors.
Suggested change
| let has_to_local = to_local_value >= local.dust_limit_satoshis; | |
| let has_to_remote = to_remote_value >= local.dust_limit_satoshis; |
Adding anchor outputs separately from the to_local and to_remote outputs prepares for HTLC outputs. Under BOLT 3, an anchor output is still added when its main output is trimmed as long as there is an untrimmed HTLC output. Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
NishantBansal2003
force-pushed
the
refactor-commitment
branch
from
September 11, 2026 18:21
48bc5ac to
effcf98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly cherry-picked some refactor commits from #181 to make the diff shorter.