S3 Implement Replication#689
Conversation
bentsku
left a comment
There was a problem hiding this comment.
Thanks a lot for jumping on this! Sorry that at the time, we didn't have the new PR templates giving more context for the documentation updates, and in my PR descriptions there were a lot of internal-only informations.
I would remove a lot of the internal details (see comments) and then I think we'd be good to go 👍
How do we want to release such documentation changes? It's already part of dev but not stable yet
|
hey @blkgrlcto looks like this still has feedback pending :) |
|
Hey @blkgrlcto we still have feedback pending 🌈 |
Co-authored-by: Ben Simon Hartung <42031100+bentsku@users.noreply.github.com>
Deploying localstack-docs with
|
| Latest commit: |
104d813
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5c5073b7.localstack-docs.pages.dev |
| Branch Preview URL: | https://doc-259-doc-s3-implement-s3.localstack-docs.pages.dev |
address PR review feedback on S3 Replication section
|
@bentsku it looks like Kiah has incorporated all your feedback, can you please review again and let us know if you approve? :) |
quetzalliwrites
left a comment
There was a problem hiding this comment.
tyvm @blkgrlcto 🐈⬛
|
Addressed @bentsku's suggestions. Ready for final review |
bentsku
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing the comments! Please note that they are 2 duplicated lines where I commented, but once this is addressed it looks ready to me! Thanks 💯
| LocalStack supports replication of object metadata — specifically tags and Object Lock settings. Metadata replication operates in two modes: | ||
| LocalStack supports replication of object metadata, specifically tags and Object Lock settings. Metadata replication operates in two modes: |
There was a problem hiding this comment.
note: there are 2 duplicate lines here
Changes
ReplicationStatusfield and its possible valuesRelated Docs tickets
ReplicationStatus)