[FSTORE-2106] Event-time-based windows for feature monitoring configurations - #647
Open
javierdlrm wants to merge 1 commit into
Open
[FSTORE-2106] Event-time-based windows for feature monitoring configurations#647javierdlrm wants to merge 1 commit into
javierdlrm wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The newly added cross-page links use relative file paths instead of the site’s heading-ID cross-reference style, which can break under mike versioning.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Documents how scheduled statistics and feature monitoring windows can be based on event time vs commit time, and how the event_time parameter controls that basis across detection/reference windows, with additional clarification for model monitoring.
Changes:
- Added a “Time basis” explanation (event time vs commit time) to the scheduled statistics guide.
- Clarified that reference windows share the configuration’s time basis in the statistics comparison guide.
- Documented
event_timeusage in Feature Group / Feature View monitoring guides (including joined Feature Group event-time selection) and noted model monitoring useslog_time.
File summaries
| File | Description |
|---|---|
| docs/user_guides/fs/feature_view/feature_monitoring.md | Adds “Time basis of the windows” guidance for Feature Views and clarifies model monitoring window time selection. |
| docs/user_guides/fs/feature_monitoring/statistics_comparison.md | Notes that rolling/expanding reference windows use the configuration’s time basis. |
| docs/user_guides/fs/feature_monitoring/scheduled_statistics.md | Introduces a “Time basis” section describing event-time vs commit-time windowing and defaults. |
| docs/user_guides/fs/feature_group/feature_monitoring.md | Adds “Time basis of the windows” guidance for Feature Groups and examples of overriding via event_time. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…rations https://hopsworks.atlassian.net/browse/FSTORE-2106 Feature monitoring windows are sliced by commit time: a rolling window over the last day reads the rows committed in the last day, so backfills and late arrivals land in the current window and feature-view windows empty their joins against slow-moving feature groups. Add an optional event-time basis: a configuration can name an event-time feature and both its detection and reference windows then select rows by that feature's value. The backend stores the feature on the configuration and event-time bounds on the statistics rows, the Python SDK gains the event_time parameter and the filter-based read path, loadtest covers both bases, and the UI and docs show the time basis. The user guides describe the two time bases and the default (the entity's event time when declared, commit time otherwise) in the scheduled statistics and statistics comparison concept pages, state that an expanding window reads the latest snapshot without a time filter on either basis, and document the event_time parameter in the feature group and feature view guides, including a feature from a joined feature group and the log_time basis of model monitoring. Reviewed-by: GitHub Copilot <Copilot@users.noreply.github.com> Reviewed-by: OpenAI Codex (GPT-5 via codex-plugin-cc 1.0.4) <codex@openai.com> Signed-off-by: Javier de la Rúa Martínez <javier@logicalclocks.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
javierdlrm
force-pushed
the
FSTORE-2106
branch
from
September 8, 2026 17:59
b5fa16d to
94699e4
Compare
javierdlrm
marked this pull request as ready for review
September 8, 2026 17:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event_timeparameter ofcreate_scheduled_statisticsandcreate_feature_monitoring, including a feature from a joined feature group, and the model monitoring section states that its windows uselog_time.Documents the sibling hopsworks-api and hopsworks-ee PRs for FSTORE-2106. Ticket: https://hopsworks.atlassian.net/browse/FSTORE-2106
Test plan
mkdocs build -swith the sibling SDK branch installed, for the API reference links