Fix review blockers: cache key, bulk card-one, Int AVET bounds - #12
Closed
tiensonqin wants to merge 1 commit into
Closed
Fix review blockers: cache key, bulk card-one, Int AVET bounds#12tiensonqin wants to merge 1 commit into
tiensonqin wants to merge 1 commit into
Conversation
Result cache now keys on db_uid plus as_of/since/history/filter_pred so shared query ASTs cannot cross-hit across DBs or temporal/filter views. Restore live-fact semantics in the O(n) bulk tx_data path for same-tx card-one re-asserts, guard Int n±1 AVET bounds at min/max_int, and add regression tests covering cache isolation, bulk updates, and range edges. Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses PR #5 review blockers:
db_uid,as_of_tx,since_tx,history, and physicalfilter_predso shared query ASTs cannot return wrong rows across DBs or temporal/filter views.tx_data— restore live-fact semantics in the O(n)by_eapath (from_dbexcludes in-tx retracts;from_accis live added facts only) so same-tx20→30→20keeps the final assert.n±1overflow atmax_int/min_intand post-filter when bounds cannot be tightened.test_query_result_cache(cross-DB, as_of, since, history, filter, toggle) andtest_bulk_card_one(re-assert regression); Int range edge cases.Also notes in the TAVE design doc which parts are shipped vs design-only.
Test plan
dune build test/test_query_result_cache.exe test/test_bulk_card_one.exedune exec -- test/test_query_result_cache.exedune exec -- test/test_bulk_card_one.exetest_query_exec_parity,test_shared_queries,test_tx_history)