Repository navigation
fix: surface graph startup errors and prepare unlock prompts - #87
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
RCmerci
force-pushed
the
fix/snapshot-admission-error-ui-20261016
branch
from
October 16, 2026 11:42
8fbd7a2 to
c645c26
Compare
RCmerci
force-pushed
the
fix/snapshot-admission-error-ui-20261016
branch
from
October 16, 2026 11:45
c645c26 to
a7c249d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a graph could stop before the journal appeared: a missing cached wrapped key required an extra Retry before reaching the encryption-password form, while a snapshot below the supported schema could leave startup loading indefinitely. Start one online key preparation after an unusable local key, show the password form only when both encrypted materials exist, and surface snapshot admission failures with their actual/minimum versions on the existing failure page and in Diagnostics.
Remote key-preparation failures stay visible with explicit Retry and graph-selection exits; they do not loop automatically. Wrong passwords remain resubmittable. New graph selection retires old key-access tickets, including account-material/private-unlock work scoped to that graph challenge, and same-account catalog reconciliation preserves a preparation failure. Opening the picker alone retains the current session. Parser/SQLite and decrypted-value errors expose fixed safe messages rather than content-bearing error text.
Validation: full
dune build @all app/native_embed.exe.oanddune runtest --forcepassed (898 Alcotest cases, 87 custom checks). New regressions were observed RED before implementation and GREEN afterward, using the owning public pure reducer for the automatic preparation and recovery states. Existing runner/transport fixtures were adapted without adding duplicate regression coverage. An isolated iPhone 13 mini Simulator passed five actual XCTest scenarios in 79.998 seconds: direct password/wrong-password/current-session resume, network/authentication recovery, graph switching before late material, schema 65.29 error/Retry/Diagnostics, and opening a schema 65.33 snapshot. The probe uses production DB/Core/Runner/Application with synthetic transport/authentication and an experimental host-restamped ARM64 object (cross_abi_validated=false); it does not prove cloud sync or full iOS cross-ABI acceptance.No real graph was migrated, deleted, reset or edited, and no real credentials or iPhone were operated. Independent review is bound to final commit
0cfa3fb1367c48839c34cfbacd7a634811dbdb51, with no remaining evidenced findings.git diff --checkand this PR's decision document pass;spec-dev-tool check --allstill reports three pre-existing incomplete decision documents. The only interface change remains the explicitly approved actual/minimum payload on storage Admission.Unsupported_schema; this UX addition changes no.mli, spec/ or Dune file.