Optimize outline parsing allocations and fast-path scalar properties - #148
Open
tiensonqin wants to merge 1 commit into
Open
Optimize outline parsing allocations and fast-path scalar properties#148tiensonqin wants to merge 1 commit into
tiensonqin wants to merge 1 commit into
Conversation
perf: reduce outline line metadata allocations
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
String.split_on_charinstead of mapping and allocating new strings.line_startswhen only an outline parse is requested viaconfig.parse_outline_only.Description
lib/syntax/md_outline.mlreplaceArray.of_list (List.map rstrip_cr raw_lines)withArray.of_list raw_linesandArray.iterito only replace CRLF lines in place, reusing the original allocations for LF inputs.line_startsallocation conditional onconfig.parse_outline_onlyso the array is not built when not needed.lib/syntax/property.mladd a cheapmay_have_referencescan for'#','[', or'('and return early when none are present, and keep the existing quoted-string check; only run the fullInline.parsewhen a reference is plausible.Testing
dune runtest, and the tests completed successfully.Codex Task