docs(market): fix Java getRankList example to use RankListOptions - #1250
Open
hogan-yuan wants to merge 1 commit into
Open
docs(market): fix Java getRankList example to use RankListOptions#1250hogan-yuan wants to merge 1 commit into
hogan-yuan wants to merge 1 commit into
Conversation
The Java example called getRankList("hot_all-us", false), but the Java
API takes a RankListOptions object (key, needArticle), not positional
args. Updated the example in all three languages (en / zh-CN / zh-HK).
Reported in #1249.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1249.
The Java example for the rank-list (人气排行榜) API called
ctx.getRankList("hot_all-us", false)with positional args, but the Java API takes aRankListOptionsobject:Updated the Java example in all three languages (en / zh-CN / zh-HK). The Rust / Python / Node.js / C++ examples in the same page were already correct.
The accompanying runtime crash (
JNI call failed) is fixed separately in longbridge/openapi#587.