Skip to content

fix(dashboard): keep clickable execution chip compact - #5345

Open
Duang777 wants to merge 1 commit into
loopx-project:mainfrom
Duang777:codex/fix-clickable-execution-chip-height
Open

Duang777 wants to merge 1 commit into
loopx-project:mainfrom
Duang777:codex/fix-clickable-execution-chip-height

Conversation

@Duang777

Copy link
Copy Markdown
Collaborator

Problem

PR #5341 changed the execution chip from a span to a button and gave the desktop button a 28px minimum height. The packaged browser smoke still enforces the existing 26px compact-row contract, so current main fails with Execution chip is not a compact hairline row: 28px tall.

Main failure evidence: https://github.com/loopx-project/loopx/actions/runs/36691337881/job/109809017646

Change

Verification

  • npm run build
  • LOOPX_PERSONAL_WORKSPACE_SCENARIO=execution-chip npm run smoke:personal-workspace-packaged
  • python scripts/chat_bundle.py verify --source
  • git diff --check

The packaged browser scenario passed on top of main@7e60e6999, including the 26px desktop assertion and 390px mobile viewport checks.

Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
@Duang777

Copy link
Copy Markdown
Collaborator Author

Exact-head CI is green on c33543eaae57f33e28c82f0c85be27216bbe785b (20 passing checks, no failures or pending jobs).

The checks include Frontstage Pages, Release Artifacts, macOS and Windows desktop builds, dashboard-acceptance, chat-bundle-browser, all three TypeScript shards, TypeScript coverage, and merge-gate. This independently clears the repeated Execution chip is not a compact hairline row: 28px tall baseline failure seen on #5338 and #5344. The mobile 44px rule remains unchanged.

Ready for maintainer review; no merge action was taken.

@Duang777

Copy link
Copy Markdown
Collaborator Author

@huangruiteng @maxliux5 This exact head remains fully green and is now the dependency blocking #5344 from resolving its main conflict without retaining the old execution-chip baseline failure. Please review when available. No merge action has been taken.

@huangruiteng huangruiteng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE — exact head c33543e; immutable base 7e60e69.

动机

这次修复针对一个已复现的显示回归:执行信息从文字变成可点击按钮后,桌面最小高度升到二十八像素,违反现有的二十六像素紧凑行约束。目标是恢复次要元信息的视觉权重,同时保留一键进入设置与移动端触控面积;不是重做工作区。

改动思路

复用现有样式和交互所有者,只把桌面按钮最小高度恢复到既有上限,不改组件、设置状态或权限。实际路径仍是工作区页头到 Steward 设置,再返回工作区,不增加信息重填或确认步骤。移动端后置媒体查询保留四十四像素;没有回调的只读路径仍展示文字,不凭样式获得写权限。

具体改动

关键代码讲解

  1. apps/presentation/dashboard/src/features/personal-workspace/personal-workspace.css:211 的 button.personal-execution-chip 是唯一修改点:桌面最小高度从二十八改为二十六,悬停、焦点轮廓与边框规则保持不变。相邻移动端覆盖仍使用四十四像素,不能把桌面压缩误读成触控目标缩小。
  2. apps/presentation/dashboard/src/features/personal-workspace/channel-header.tsx:9 的 ChannelHeader 是实际消费者。它在已有设置回调存在时生成按钮,否则保留文字分支;按钮继续调用原来的设置导航,不提交配置。已检查工作区页面的设置入口与返回路径,没有新增状态所有者、备用写入路径或不可达的抽象。

对主干的风险

主要风险是桌面压缩连带损伤移动端或键盘操作。我亲自构建两端相同夹具:旧基线原生 packaged smoke 明确因二十八像素失败,当前 head 通过;独立浏览器读到桌面二十六、移动端四十四,均无横向溢出。整屏检查、键盘 Enter 打开设置和返回均完成,独立回读配置写入计数为零。当前 build、bundle verify、已有 packaged scenario、diff check 通过。构建的大 chunk 提示基线也存在,不是失败或本 PR 阻塞。使用真实构建前端和合成 API,不声称已安装 App、真实后端持久化或线上排序已验证;这些所有者未变。

我的整体评价

这一行足以完整修复当前回归,长期运行影响为保留,用户体验为改善;未增加步骤、协议或义务。未来向简化检查认为已有样式与 smoke 已能定位问题,无需额外组件或测试框架。无可发布的阻塞发现;这不是 opt-in 功能,也没有权限或类型化状态语义变化。评审未查询或等待远端 CI,APPROVE 不代表代替维护者合并或安装。

English verdict: APPROVE - The exact-head one-line desktop fix is validated against the immutable base, preserves mobile and keyboard access, and changes no runtime authority.

@huangruiteng

Copy link
Copy Markdown
Collaborator

Merge-readiness requalification (not a new review)

Exact head: c33543eaae57f33e28c82f0c85be27216bbe785b. The existing exact-head approval remains valid; this action reuses that review rather than inventing a new verdict or claiming new UI validation.

The current loopx pr-review --check-merge-readiness result is not ready, with only merge_state_requires_update: GitHub reports BEHIND. Update the branch against its base, then qualify/review the resulting new exact head before a maintainer merges. No merge or admin bypass was performed.

CI policy is not_consulted; this base-update hold is not a REQUEST_CHANGES finding and is not an assertion that unrelated red CI was caused by this PR.

中文:当前精确-head 批准继续有效;这次是 capability 指定的合并就绪复查,不重复提交评审。当前仅因分支落后主干而暂不就绪,请更新分支后对新 head 复核,再由 maintainer 合并。没有合并,也没有把无关红 CI 作为 Request Changes 理由。

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants