Conversation
Signed-off-by: karenchuu <25980598+karenchuu@users.noreply.github.com>
Contributor
Author
|
Closing this to avoid two competing copies of the same change. The content is re-pushed under the account this work belongs to, rebased onto What changed between #5350 and #5351:
No content differs otherwise: same 14 files, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralizes the identical compact public-safe reference, compact token, and module-qualified surface regular expressions in
loopx/public_safe_text.py. Reward Memory, Semantic Preference, Decision Context, and Material Lifecycle retain their existing field-level behavior and error messages while consuming the shared compiled patterns.Also adds a focused ownership regression test that verifies the listed consumers share the owner objects and no longer restate the literals.
Delivery brief
loopx/public_safe_text.pyowns syntax shapes, while callers retain contract-specific policy and diagnostics.Validation
uv run --extra test pytest -q tests/control_plane/test_compact_identifier_shape_owner.py tests/capabilities/test_decision_context_packets.py tests/capabilities/test_decision_context_profile.py tests/capabilities/test_reward_memory_ingestion.py tests/test_reward_memory_pipeline.py— 61 passeduv run --extra test ruff check …— passedgit diff --check— passedScope