Repository navigation
Conversation
lqiu96
force-pushed
the
perf/bq-t1-04-timestamp-parsing-and-option
branch
6 times, most recently
from
October 13, 2026 22:07
4fd8299 to
e7fccb2
Compare
…id BigInteger in getTimestampValue
lqiu96
force-pushed
the
perf/bq-t1-04-timestamp-parsing-and-option
branch
from
November 19, 2026 19:43
e7fccb2 to
c273743
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to googleapis#14889 (which applied
DataFormatOptionstotabledata.listrequests):HttpBigQueryRpc.getQueryResultsSkipExceptionTranslation: Propagates non-defaultDataFormatOptions(formatOptions.useInt64TimestampandformatOptions.timestampOutputFormat) onjobs.getQueryResultsrequests, matchinglistTableDataSkipExceptionTranslation. Default requests omitformatOptions.FieldValue.getTimestampValue(): UsesLong.parseLong(getStringValue())instead ofnew BigInteger(getStringValue()).longValue()whenuseInt64Timestampsis enabled, avoiding aBigIntegerallocation per cell.Verification
mvn test -pl java-bigquery/google-cloud-bigquery -Dtest=FieldValueTest,HttpBigQueryRpcTest,BigQueryImplTest -Dclirr.skip=true -Denforcer.skip=true -Dflatten.skip=true(244 passed)