Skip to content

fix(bigquery): propagate DataFormatOptions to getQueryResults and avoid BigInteger in getTimestampValue - #9

Open
lqiu96 wants to merge 1 commit into
mainfrom
perf/bq-t1-04-timestamp-parsing-and-option
Open

lqiu96 wants to merge 1 commit into
mainfrom
perf/bq-t1-04-timestamp-parsing-and-option

Conversation

@lqiu96

@lqiu96 lqiu96 commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

Follow-up to googleapis#14889 (which applied DataFormatOptions to tabledata.list requests):

  • HttpBigQueryRpc.getQueryResultsSkipExceptionTranslation: Propagates non-default DataFormatOptions (formatOptions.useInt64Timestamp and formatOptions.timestampOutputFormat) on jobs.getQueryResults requests, matching listTableDataSkipExceptionTranslation. Default requests omit formatOptions.
  • FieldValue.getTimestampValue(): Uses Long.parseLong(getStringValue()) instead of new BigInteger(getStringValue()).longValue() when useInt64Timestamps is enabled, avoiding a BigInteger allocation per cell.

Verification

  • mvn test -pl java-bigquery/google-cloud-bigquery -Dtest=FieldValueTest,HttpBigQueryRpcTest,BigQueryImplTest -Dclirr.skip=true -Denforcer.skip=true -Dflatten.skip=true (244 passed)

@lqiu96
lqiu96 force-pushed the perf/bq-t1-04-timestamp-parsing-and-option branch 6 times, most recently from 4fd8299 to e7fccb2 Compare October 13, 2026 22:07
@lqiu96 lqiu96 changed the title fix(bigquery): [T1-4] propagate useInt64Timestamp to listTableData/getQueryResults and optimize FieldValue.getTimestampValue fix(bigquery): propagate DataFormatOptions to getQueryResults and avoid BigInteger in getTimestampValue Nov 19, 2026
@lqiu96
lqiu96 force-pushed the perf/bq-t1-04-timestamp-parsing-and-option branch from e7fccb2 to c273743 Compare November 19, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant