Repository navigation
Add a Show menu to the Search panel for the media filter - #429
Merged
Merged
Conversation
Choosing between images, videos and both meant opening the semantic map. A new icon between Bookmarks and By Map opens a small menu, and the icon changes to show the active mode: a camera for images, a clapper for videos, and the two together for both. The picture frame was already taken by By Image. The map's radio buttons are redundant now and are removed. The control is greyed out for an album holding only one kind, whose reason it gives in a tooltip. If /media_indices fails it stays usable, because the map classifies its own points and may still be filtered. media-filter.js gains albumMediaMix() and a mediaIndicesUpdated event, since mediaFilterChanged deliberately stays quiet when nothing was or is filtered. A seventh icon overran the panels, so the icon rows tighten at 601-860px and step down to 40px buttons below 430px. Stacked panels also use border-box, which stops their rows sitting off-centre and clipping on the right. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Choosing between images, videos and both used to mean opening the semantic map. A new Show icon in the Search panel, between Bookmarks and By Map, opens a small menu, and the icon changes to show the active mode. The map's Images/Videos/Both radio buttons were redundant after that, so they are removed.
Behaviour
setMediaFilter, so the swiper, grid, search and map react just as they did to the radios./media_indicesfails: Show stays usable and the tooltip says the list could not be read. The map classifies its own points and may still be filtered, so this is the only way to change it.media-filter.jsgainsalbumMediaMix()and amediaIndicesUpdatedevent, becausemediaFilterChangeddeliberately stays quiet when nothing was or is filtered.Layout
The seventh icon overran the panels, and these changes also affect the Control panel:
box-sizing: border-box, which fixes rows sitting off-centre and clipping on the right.Known limitations
Testing
npm test(1036 passing), plus lint and format checks.pytest testspassed before the radio removal and review fixes; those later changes only touch frontend files and docs./media_indices.🤖 Generated with Claude Code