Conversation
A terminally failed provider-turn.start left the run starting after the session had already opened, so settle stayed blocked and the composer never offered Stop. Settle that failure once retries are exhausted, and treat preparing and starting runs as interruptible. Co-authored-by: maco <macodev00@users.noreply.github.com>
github-actions
Bot
added
vouch:trusted
Owner
Author
|
Not opened upstream: targets an unreleased branch, not main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
When
provider-turn.startfails for the last time after the provider session has already opened, the run is settled as failed instead of stayingstarting. The composer Stop control, andthread.stop, are offered for preparing and starting runs.Why
A Pi turn that died during resume/ensure left the outbox failed and the run
startingwithstartedAt: null. Settle stayed blocked because the run still looked active, and the desktop composer hid Stop because that state is the connecting phase. Retryable attempts still leave the run starting. An interrupt is not turned into a failure, and a run that was already interrupted is left alone. Queued runs stay non-interruptible.Fixes pingdotgg#13392
UI Changes
Stop is the primary composer control while a preparing or starting run can be interrupted, including when the draft already has text. A running turn still shows Steer once there is something to send.
Checklist