Fix Redis TryAcquireAsync handling for disconnected databases#283
Open
teesofttech wants to merge 1 commit into
Open
Fix Redis TryAcquireAsync handling for disconnected databases#283teesofttech wants to merge 1 commit into
teesofttech wants to merge 1 commit into
Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Redis TryAcquireAsync behavior in RedLock when one or more IDatabase instances are disconnected (where StackExchange.Redis may backlog operations instead of failing fast), ensuring disconnected cases surface promptly and correctly without masking real underlying faults.
Changes:
- Update
RedLockAcquire.WaitForAcquireAsyncto properly propagate the synthetic “disconnected database” fault when it becomes decisive and no real faulted/canceled acquire tasks exist. - Adjust the disconnected-database decisiveness logic so a single disconnected database is immediately decisive in the single-server scenario.
- Add CI tests covering: single-db disconnect throws, synthetic disconnect does not mask a real fault, and single-db contention returns
null.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/DistributedLock.Tests/Tests/Redis/RedisDistributedLockTest.cs | Adds targeted CI tests validating TryAcquireAsync outcomes for disconnected and contended Redis database scenarios. |
| src/DistributedLock.Redis/RedLock/RedLockAcquire.cs | Fixes fault propagation for synthetic disconnect faults and refines decisiveness logic for single-database acquisition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.