refactor(cloudflared): read the tunnel token from a docker secret - #303
Merged
Conversation
BREAKING CHANGE: Create the `cloudflared-tunnel-token` secret before deploying, then drop `CLOUDFLARED_TUNNEL_TOKEN` from `.env`.
dargmuesli
changed the title
|
🎉 This PR is included in version 21.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TUNNEL_TOKENis the only credential in the stack passed as an environment variable.Everything else, including both Cloudflare API tokens Traefik uses for the DNS challenge, already goes through Docker secrets.
The token grants the ability to serve traffic for the tunnel, so as an environment variable it is readable through
docker service inspectby anyone with Docker API access, and it sits in.envon disk instead of the swarm's encrypted raft store.cloudflaredreads the token from a file given by--token-file/TUNNEL_TOKEN_FILEand trims surrounding whitespace, so a secret written with or without a trailing newline works.The secret is declared
external: true, matching how the two Traefik tokens are already handled.Create it before deploying, then drop
CLOUDFLARED_TUNNEL_TOKENfrom.env: