Fix native plugin hooks ignored by Claude - #87
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude silently ignored compiled plugin hooks because the manifest contained
hooks.hooksinstead of an inline event map. Flatten the compiled hooks so authorized SessionStart hooks run, preserving the existing admin-only gate.Live testing of the previous candidate reproduced the warning
hooks.hooks: unknown hook eventand zero registered hooks. The corrected scratch manifest produced exactly one hook marker; fixed-source real-engine verification passed: separate native command/agent runs each produced exactly one hook marker; Claude and Codex portable reads and MCP calls also passed. Separate command and inspector acceptance prompts to avoid command instructions contaminating the agent result. Correct the last-good revision regression to assert the real revision field.Validation: focused compiler/import tests passed. Full coverage passed (2,499 pass, zero fail, 11 opt-in skips); static checks, history-inclusive secret scan, security coverage, high-severity audit threshold, DCO across main..HEAD, container check and fixed-source live subsets passed. CI status is recorded below by GitHub. Full release acceptance remains open; this fixes a beta defect and does not authorize stable promotion.