fix: select plugin MCP declarations for each engine - #88
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages with separate Claude and Codex MCP declarations could send Codex to Claude's endpoint. Referenced JSON configurations were also combined across engines, causing duplicate server-name failures.
Select each engine's source manifest independently from native plugin output, and retain per-engine MCP paths while preserving aggregate policy checks and single-manifest compatibility. Add failing-before/fixed-after regressions for inline and referenced declarations and update feature and acceptance documentation.
Validation: full suite 2,501 passed, 11 opt-in tests skipped, zero failures; coverage floors, static checks, secret scan, security coverage, dependency audit at high threshold, and DCO passed. Independent review approved and eight additional compatibility combinations passed. Isolated actual-engine acceptance is in progress; the full live plugin import/review/grant/revoke matrix remains unexecuted. This PR targets beta only.