Repository navigation
Switch Time Travel comparisons in a single frame - #648
Merged
Merged
Conversation
Opening or changing a slider comparison could show the original alone with the curtain hidden, the previous comparison at the next framing, a black frame or a first frame with the default curtain while the next pair loaded. - SliderComponent.preload(ids) caches a pair, including image assets, without showing it, so a following configure with the same ids switches within one frame. - Pair options (viewAligned, mode, viewScale, viewCorrection, visibility) apply only once the state shows the configured pair. - A cached pair swaps before the next frame (StateService.lastState$). - The slider leaves traversal before changing the trajectory, and a newly activated slider applies its curtain together with its first GL update. - SliderGLRenderer clears before drawing, so it never composites over another background renderer active in the same frame. - A disposed TextureProvider ignores late region-of-interest updates and tiles instead of throwing on its released renderer. Regression tests: SliderPreload, SliderPairConfiguration, SliderExclusiveBackground, TextureProviderDisposed and updated SliderSelectionFraming, SliderAutomaticMotion and SliderViewAligned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening or changing a slider comparison could briefly show the original alone with the curtain hidden, the previous comparison at the next framing, a black frame, or a first frame with the default curtain while the next pair loaded.
Changes
SliderComponent.preload(ids)caches a pair, including image assets, without showing it, so a followingconfigurewith the sameidsswitches within one frame.viewAligned,mode,viewScale,viewCorrection, visibility) apply only once the state shows the configured pair; the shown pair keeps its own options while the next one loads.StateService.lastState$, the replayed latest frame).SliderGLRenderer.renderclears before drawing, so it never composites over another background renderer still active in the same frame.TextureProviderignores late region-of-interest updates and tiles instead of throwing on its released renderer.Testing
yarn lint,yarn build,yarn test(1,735 tests, 128 suites) pass locally.SliderPreload,SliderPairConfiguration,SliderExclusiveBackground,TextureProviderDisposed; updatedSliderSelectionFraming,SliderAutomaticMotion,SliderViewAligned.