Fix LightningCSS.bundle to report its exports and warnings - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes
bundleanswer the same complete resulttransformdoes. It was hardcodingexports: Noneandwarnings: Vec::new(), so both came back empty however the bundle was compiled.Compiling a bundle as a CSS module renamed every name it read and then reported none of them, which left the caller holding hashed class names and no way to map them back.
exportswasnilfor a bundle where a transform of the same stylesheet answered a map.Warnings had the same shape of problem. The parser's warnings sink was never installed for a bundle, so a rule Lightning CSS kept but could not act on went unreported, and
warnings?answeredfalsefor a stylesheet that had something to say. The sink is shared across every file the bundler reads, so a warning coming out of an imported file now surfaces and names the file it came from.