Fix Options to refuse allowed and subject as option names - #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes two option names being silently swallowed instead of refused.
allowedandsubjectwere keyword parameters onOptions.new, so**optionscould collide with them and they never reachedvalidate!.Every other unknown option raises. These two quietly reconfigured the validator and then went missing from the JSON that reaches the native library.
Both are positional arguments now, so no option name can reach them, and the two cases above raise the same way anything else unknown does.
Breaking change
Options.newandOptions.serializetake the options hash as their first argument.LightningCSS.transform,bundle,minifyandtransform_style_attributeare unaffected, so this only reaches code buildingOptionsdirectly.Neither name was usable as an option before this, since
allowedcould only narrow whatKNOWNalready permits andsubjectonly changes the wording of an error. Nothing was silently dropped that a caller could have meant.