Don't leave the Rust build directory behind on a source install - #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request stops a source install leaving Cargo's build directory inside the installed gem.
extconf.rbrunscargo buildfrom the gem's ownrust/directory, sorust/targetis written inside the gem and stays there once the install finishes. Nothing removes it. On a platform without a precompiled gem, every install leaves several hundred megabytes of Rust intermediates sitting in the gem directory forever.The static library is the only thing the link step needs, so it is copied into
ext/and the build directory is removed beforemakeruns.A working checkout is told apart from an installed gem by the presence of
.git, sorake compilekeepsrust/targetand incremental builds are unaffected. Only the installed-gem path cleans up.Precompiled gems never reach this branch at all, since they ship the built extension and do not run
cargo.