Use hyphens, not underscores, in generated GitHub repository URLs

[mariushelf]

Generated projects now point their GitHub URLs at the hyphenated repository name, so project_slug = auto_shopper gives github.com/<user>/auto-shopper. The full suite passes (31 tests), and the work is committed with a clean tree. I did not push.

What changed

• template/pyproject.toml.jinja: the Homepage and Repository URLs use {{ project_slug | replace('_', '-') }}.
• template/README.md.jinja: the CI badge image and link (line 3) and the "Original repository" link (line 9) use the same expression.
• tests/test_template.py: a new test, test_github_urls_use_hyphenated_repo_name, runs for both the hexagonal and flat layouts. For each it renders the template without uv sync and checks three things:
  • the pyproject.toml URLs equal https://github.com/testuser/test-project;
  • every github.com/testuser/... URL in README.md uses test-project;
  • no rendered file contains github.com/testuser/test_project.

Test-first check: before the fix, both cases failed on the pyproject.toml URL assertion. After the fix, both pass.

Commits

• 17a41a4 — test: assert generated GitHub URLs use hyphenated repo name
• 2be5cb3 — fix: use hyphens in generated GitHub repository URLs

Risk

• Low. I touched only the three URL lines, so import paths, the src/ package directory and the import-linter contracts still use the underscored slug. The existing import, lint and generated-test checks in the suite pass.
• Already generated projects are not migrated; copier update picks up the change.
• No new copier question was added. The repository name is derived from the slug, as the spec assumed.
• The plan and spec agreed, so there was nothing to reconcile. graphify update . was skipped because this worktree has no graphify-out/.

Fixes #16

~Written by Claude, run via the agentic engineering loop

[mariushelf]

Build complete.

Cost: build $0.25 (sonnet, effort high) · ticket total $0.78 · API list price

~Written by Claude, run via the agentic engineering loop

[mariushelf]

Review round 1 — approve

Approve. The change pipes project_slug through replace('_', '-') in the GitHub URLs at template/pyproject.toml.jinja:28-29 and template/README.md.jinja:3 and :9. This matches the existing distribution-name derivation. The wheel packages entry, the import-linter contracts and the src/ paths keep the underscored project_slug.

A new parametrized test, test_github_urls_use_hyphenated_repo_name, checks the pyproject URLs and the README URLs. It also scans every rendered file for an underscored repository URL, in the hexagonal layout and in the flat layout.

The riskiest criterion is that the test fails against the old template. Decisive evidence: with the two template files restored from c4ea508, both parametrized cases failed. With the fix in place, the full suite passed, 31 tests.

The diff also adds the loop artifacts plan/issue-16.md and spec/issue-16.md. tasks/pr-comments.md contains no review flags.

Acceptance criteria

• In a project generated with project_slug = "test_project" and github_username = "testuser", pyproject.toml has Homepage and Repository equal to https://github.com/testuser/test-project.: met
• In the same project, every github.com/testuser/... URL in README.md uses test-project, and none uses test_project.: met
• No other generated file contains github.com/<github_username>/<project_slug> with an underscore (checked by grep over the rendered project).: met
• A test in tests/test_template.py renders the template and asserts the two criteria above, and fails against the current template.: met
• Python import paths, the package directory under src/, and import-linter contracts still use project_slug with underscores (existing tests stay green).: met

Cost: review $0.36 (opus, effort high) · ticket total $1.14 · API list price

~Written by Claude, run via the agentic engineering loop

[mariushelf]

Review verdict: approved (tier 0)

~Written by Claude, run via the agentic engineering loop

[mariushelf]

Cost summary (API list price)

Stage	Model	Effort	Attempts	Cost
plan	opus	high	1	$0.53
build	sonnet	high	1	$0.25
review	opus	high	1	$0.36
Total			3	$1.14

~Written by Claude, run via the agentic engineering loop