Repository navigation
feat(iec10x): M1 typed command/RTU response forensics and quality SSOT (#39) - #40
Merged
masarray merged 23 commits intoOct 28, 2026
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+273
to
+274
| if (row.Source.CommandDetails is { } cmd104) | ||
| yield return new ProtocolMapLine("command", "Command / RTU response", cmd104.Detail, CommandEvidence(row, bytes, 6)); |
Comment on lines
+462
to
+468
| foreach (var token in tokens) | ||
| { | ||
| if (token == "-") continue; | ||
| if (token.Length > 2 && (token.Length & 1) == 0 && token.All(Uri.IsHexDigit)) | ||
| for (var i = 0; i < token.Length; i += 2) bytes.Add(token.Substring(i, 2)); | ||
| else bytes.Add(token); | ||
| } |
…l-link and passive; correct CP56 DOW
…serve time validity and IEC-103 E5 semantics
masarray
marked this pull request as ready for review
October 28, 2026 13:30
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements M1 of #39 on isolated branch based on 2026-10-28 master
0bf7b41c.Included
Protocol safety
Link ACK != command execution; ACTCON != physical operation proof. No change to polling/FCB, no passive TX. No individual flag columns.
Scope boundaries
Command transaction lifecycle correlator, per-byte highlight parity for all link-address widths, full event provenance, report/replay SSOT parity and actual WPF badge templates remain planned (not claimed here); see
docs/UNIFIED_PROTOCOL_COMMAND_FORENSICS_M1.md.Validation
CI is required; local environment does not have the .NET SDK, so tests were not run locally. Do not merge until all Windows checks pass.