Repository navigation
fix(WPF): instant IEC-101 live Trace and engineer-readable full line monitor - #42
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4bca8eddee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (item.Frame is { IsChecksumValid: false }) | ||
| return ($"{prefix} INVALID FT1.2 FRAME", "Checksum/format invalid or incomplete; consult exact raw bytes."); |
There was a problem hiding this comment.
Validate frame integrity before narrating link responses
For checksum-invalid IEC-101 frames that still have a decoded control byte, every path inside if (link is not null) returns before this integrity check. Both Ft12Parser and the passive monitor populate LinkControl for such frames, so a corrupted FC0 or FC9 is now displayed as an ordinary LINK ACK or DATA NOT AVAILABLE response, replacing the previous quality warning in ProtocolTraceMeaning. This hides relevant line-fault evidence during passive capture and replay. Check checksum and format validity before interpreting link functions, or explicitly retain the integrity warning alongside the tentative interpretation.
Useful? React with 👍 / 👎.
Field evidence / reproduction
Screenshots show IEC-101 COM1 at 1200 8E1 Link 105 flashing TX/RX/FC9 while Trace is blank until navigating away and back. independent IEC-101 reference benchmark displays every direction with raw+interpreted FT1.2/ASDU, class request, FC9, ACD/DFC, COT and value/time.
One focused implementation batch (from M2 merged master aa9f009)
Gates
Windows Release build, formatter, 19 protocol smoke, full xUnit, GUI package, CodeQL, dependency/hygiene. Merge only on green and exact SHA. Physical SICAM/ETERA/independent IEC-101 reference same-session FAT remains outstanding; CI does not prove physical hardware parity.