Repository navigation
fix(WPF): crisp ClearType Trace and byte-accurate selected Frame Interpreter #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
masarray
merged 2 commits into
master
from
fix/iec101-crisp-trace-byte-inspector-20261029
Oct 28, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # WPF Trace readability + byte-true IEC-101 Inspector (2026-10-29) | ||
|
|
||
| ## Screenshot reproduction | ||
| At 1526x955, live Trace labels and HEX looked jagged/faint. Existing XAML directly overrode the theme's ClearType/Ideal text default with `TextFormattingMode="Display"` and ~10.5 DIP monospaced font across explanatory prose; Inspector used tiny two-column labels, noisy generic prose and fake raw chips (e.g. `L=105,CA=1,IOA=...` instead of hex). | ||
|
|
||
| ## Fix | ||
| - Trace title/meaning rendered in normal AppFont (Segoe UI/Aptos), 12.8/12.2 DIP, 18-DIP lines, darker ink and **Ideal + ClearType**, preserving light ListBox virtualized 1200-row bounded display; raw HEX uses Cascadia Mono/Consolas 11.6 DIP with Ideal + ClearType and no shadow, animation or per-frame additional UI. | ||
| - Inspector uses neutral white background; larger 11.9-12.2 DIP type and simple compact field + HEX + decoded value layout, not a large lecture-style two-column table. | ||
| - New **pure `Iec101FrameByteInspector.Explain`**, invoked only when a frame is selected, maps actual FT1.2 byte offsets and already-decoded ASDU information-object offsets into linked field/HEX groups; WPF receives one identical list as both HEX highlights and field explanations. Shows Start/L, Control (PRM/FCB/FCV or ACD/DFC), Link Address, Type ID, VSQ, COT, CA, *each* IOA, value/quality/CP56 time and checksum/integrity. It never invents an address string as HEX, and never reparses the original serial telegram. | ||
| - Each chip/field has a stable shared key, including object-N/value-N for multiple IOAs. Default focus is first value if decoded, else control. Typed check and raw byte length guard prevents out-of-bounds extraction. Unknown fields explicitly remain unknown; invalid checksum/length cannot become Good. | ||
| - Copy decoded frame uses the same field map as Inspector, not generic prose. | ||
| - IEC-103/104 Inspector branches remain unchanged; no changes to serial/TCP I/O, polling, FCB, passive RX-only or backpressure semantics. | ||
|
|
||
| ## Performance / FAT | ||
| Layout/font-only WPF changes; decoder usage restricted to selected Inspector frame. No new timers, repeated UI updates, polling, font dependencies, animations or bitmap buffers. 1200-row virtualization and 75ms batching unchanged. | ||
|
|
||
| **Field FAT required**: test Windows display scaling 100%, 125%, 150% with COM 1200 bps and same SICAM setup, immediate Trace first paint, long streaming readability/no stutter; select 1-octet and 2-octet address frames, multi-IOA, FC9/ACD, Type30/CP56, invalid checksums; every HEX chip must match exact raw slice and update linked field highlight. Test screenshot legibility and compare ASE2000. CI is not visual proof of hardware rendered text. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change replaces the inspector's two-column field layout with stacked field/hex/meaning rows and changes trace sizing, but only adds a standalone FAT document. The root
AGENTS.mdexplicitly requires updatingdocs/RESPONSIVE_LAYOUT_POLICY.mdwhenever layout changes; that policy is untouched in this commit. Update the canonical policy to describe the revised inspector layout and its bounded scrolling behavior rather than documenting the change only in this dated checklist.AGENTS.md reference: AGENTS.md:L215-L215
Useful? React with 👍 / 👎.