Repository navigation
MMS Write: fail closed on invalid single-variable response cardinality - #195
Merged
masarray merged 4 commits intoOct 23, 2026
Merged
Conversation
masarray
marked this pull request as ready for review
October 23, 2026 06:03
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First isolated Phase A implementation slice for ARSAS global typed MMS Write handoff. The existing single-variable MMS Write decode now refuses zero or multiple access results (rather than treating >1 successes as proof of one requested DA). Adds BER negative tests for 0/2 results and wrong invokeID. Does not modify production engine pin, control sequence, ARSAS #679, or live IED; no compiled or physical FAT claim. Remaining: run .NET CI, exact type/schema validator, consumer WPF single DA and multi-DA UX, verified browser control eligibility, Windows x64 release.