Repository navigation
P0 MMS: fail-closed abbreviated DatSet/RptID cross-RCB routing (#707) - #198
Merged
Merged
Conversation
masarray
marked this pull request as ready for review
October 27, 2026 23:26
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P0 reporting integrity: reject contradictory shortened DatSet identities before routing MMS Report
Reconciled evidence
ARSAS issue #707 documents a successful 2026-10-24/25 SG7 FAT (77/77, 4/4 RCB) but a later association with 56/77, 1/4. The ARSAS monitoring code and pinned ARIEC engine are byte-identical between these runs. This PR does NOT claim the missing 3 SG7 reports were received or fix the 21 pending values.
Independent source audit found an actionable correctness hole in
MmsClientSession.SelectPersistentReportMonitor: a unique matchingRptIDwith a contradictory abbreviated reported DataSet (LLN0$DS_B) could be routed to an unrelated member order (IEDLD0/LLN0.DS_A). Full domain-qualified DatSet conflicts already failed closed; short DatSet conflicts did not.Precise fix
LN$DS, only accept an exact LN+DS suffix at an explicit/boundary, or an exact abbreviated plan.DS, compare its explicit tail; omitted DatSet remains legacy-RptID-compatible.Regressions
MmsPersistentReportRoutingTestscovers full, abbreviated, and tail-only positive compatibility; wrong DataSet/LN negative checks; and all 4 SG7 DataSet/RCB identities independently routed regardless of registration order. No private IED captures.Exact base engine
stagingatf75e323e9f8443aa20e0a3818a1d5d77255b2c0f; headca502b89989b5d5eb137ed7b1fa70b7a98eda658. Only 2 files changed. PR kept draft until real CI and review. The ARSAS app pinned-engine lock remains unchanged and no stable release or hardware acceptance is implied.