Repository navigation
P8 reporting: reject type-conflicting structured MMS FCD leaves before scalar projection - #199
Merged
Merged
Conversation
masarray
marked this pull request as ready for review
October 29, 2026 12:09
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P8 major reporting integrity milestone — typed FCD leaf validation, zero false process publication
Why / global engineering context
Engine issue #159 documents the C264 structured-FCD safety gap: a received
Structureis different from an RCB that never sent any frame. Previously the semantic projector validated structure child counts and model paths, but did not validate the declared exact MMS type of each positional leaf. Example: a receivedutc-timevalue at the model's exactq:bit-stringposition could be interpreted through the generic fallback. A wrong quality/timestamp association must never result in a convincing but false scalar process value.Engine changes (one atomic commit / 2 files)
REPORT_SEMANTIC_REJECTEDreason. Other members of the same received Report remain independent.Deterministic regression
Positive ordered float/float/bit-string/utc-time; negative swapped q/t with no false process values, contradictory exact model metadata, and positive unknown/partial model compatibility. Existing semantic structured tests remain in place. Conservative limitation: equal-type siblings cannot prove physical leaf order; this PR does not claim full wire/physical certification.
Exact baseline engine
staging5923029a8b98ea841cc36db6f20c2ea80d21547c; candidate headb34c687264e3fc7b22ddeb6699bf9b7da2eafb14. One atomic source commit so the PR triggers one CI wave. Keep DRAFT until exact-SHA .NET full CI passes and review is clean. Does not alter ARSAS engine pin, stable release, nor claim that SG7 #707 (56/77 vs 77/77) is fixed.