fix(arch): add support for Windows arm64 - #24
Open
advait-m wants to merge 1 commit into
Open
Conversation
PLATFORM_MAPPINGS has no `win32-arm64` entry, and the only fallback is
the universal build on darwin. On a native Windows arm64 runner (for
example GitHub's `windows-11-arm` images) `process.arch` is `arm64`, so
the action fails with:
Error: TypeError: Unsupported platform: win32/arm64
sentry-cli publishes `sentry-cli-Windows-aarch64.exe` alongside the
i686 and x86_64 builds, so map `win32-arm64` to `Windows-aarch64` the
same way `linux-arm64` maps to `Linux-aarch64`.
Co-Authored-By: Warp <agent@warp.dev>
advait-m
added a commit
to warpdotdev/warp
that referenced
this pull request
Aug 24, 2026
Replaces the hand-rolled install script with a pinned reference to
warpdotdev/setup-sentry-cli, a fork of matbour/setup-sentry-cli carrying
the one-line platform mapping upstream is missing:
'win32-arm64': 'Windows-aarch64',
That fix is submitted upstream as matbour/setup-sentry-cli#24. Pointing
at the fork keeps this call site configured exactly like the other eight,
so reverting is a one-line change to the `uses:` reference once upstream
releases the fix, rather than deleting a bespoke script.
Only the Windows call site moves to the fork. The other platforms work
fine on upstream, and leaving them there keeps currently-healthy release
legs off a fork they do not need.
Co-Authored-By: Warp <agent@warp.dev>
3 tasks
advait-m
marked this pull request as ready for review
August 24, 2026 14:36
Author
|
@matbour tagging you for review - thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a native Windows arm64 runner, the action fails outright:
PLATFORM_MAPPINGSinsrc/get-download-link.tshas entries forwin32-x32andwin32-x64, but none forwin32-arm64, and the only fallback covers darwin:This is increasingly easy to hit now that GitHub offers native Windows arm64 runners — anything that previously cross-compiled to arm64 on an x64 host (where
process.archwasx64) breaks when moved onto a native arm64 host.Fix
sentry-cli already publishes a Windows aarch64 binary next to the i686 and x86_64 ones, so this only needs the mapping entry:
This mirrors how
linux-arm64maps toLinux-aarch64.Verified the asset exists and is the right architecture:
Changes
src/get-download-link.ts— the mapping entry (the actual fix).dist/main.js/dist/main.js.map— rebuilt withpnpm build, since the bundle is committed and is whataction.ymlruns. The only semantic change in the bundle is the new mapping entry.README.md— added thewin32 / arm64 (aarch64)row to the supported-architecture table.I confirmed
dist/rebuilds byte-for-byte from unmodifiedmainbefore making the change, so the bundle diff here is purely this fix and not build-environment drift.pnpm lintandpnpm typecheckboth pass.I left
CHANGELOG.mdalone since entries there look like they're added per release rather than per PR — happy to add one if you'd prefer..