Repository navigation
Tensor space - #1970
Tensor space#1970Tragicus wants to merge 3 commits into
Conversation
|
This looks nice, thank you for making this PR! Could you tell me what the \pi_Q map represents? Could you point me to the universal property for the binary tensor product within the code, so that I can start from here? More generally, happy to help on this PR, tell me what I can do. |
|
If |
|
|
||
| Variable (W : lmodType R). | ||
|
|
||
| Definition tensor_umap (f : U -> V -> W) (t : tensor) : W := |
There was a problem hiding this comment.
This is half of the bijection, which turns a bilinear map from U and V to a linear map from the tensor product (see the instance below).
|
@CohenCyril who is working on this PR? |
|
(doc in progress, changelog to be done) |
| (* : the vector space whose basis is `T` *) | ||
| (* *) | ||
| (* `free_lmod_unit x` or `x%:lmod` *) | ||
| (* : This is the unit of the monad. *) |
There was a problem hiding this comment.
of the monad : which monad ?
There was a problem hiding this comment.
free_lmod_unit and a specialized version of free_lmod_eval make free_lmod a monad.
Motivation for this change
Binary and indexed product tensor spaces.
@CohenCyril I have little recollection of what we did, so I have no idea what the status of this is. In particular, I see the universal property of the binary tensor space but not the general product one.
@mkerjean FYI
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers