Skip to content

fix #1911 - #2139

Open
affeldt-aist wants to merge 2 commits into
math-comp:masterfrom
affeldt-aist:fix_1911
Open

affeldt-aist wants to merge 2 commits into
math-comp:masterfrom
affeldt-aist:fix_1911

Conversation

@affeldt-aist

Copy link
Copy Markdown
Member
Motivation for this change

fixes #1911

fyi: @CohenCyril @pi8027

Checklist
  • appended entries in the relevant sections of CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are likely to be merged as they are into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

Co-authored-by: Quentin Vermande <quentin.vermande@orange.fr>
@affeldt-aist affeldt-aist added this to the 1.19.0 milestone Oct 22, 2026
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Oct 22, 2026
Comment thread classical/unstable.v Outdated
Export Norm.Exports.

Definition with_basis {K : fieldType} {E : vectType K} {B : (dim E).-tuple E}
of basis_of fullv B : Type := E.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not R : nzSemiRingType and E : semiVectType R?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basis_of has the following type:

basis_of : forall {K : fieldType} {vT : vectType K}, {vspace vT} -> seq vT -> bool

:-(

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vector space with basis

2 participants