Conversation
Scroll the toggle to the viewport centre before clicking; under Chrome 149 it could otherwise be reported as 'not clickable' when behind a sticky header.
page.click() reports the Materialize lever as not clickable on the new Chrome even after scrolling it into view; dispatching the click directly fires the toggle handler reliably.
After enabling the queue toggle the submit opens a password-confirmation modal; under the modern headless Chrome its input is not focusable and its confirm button not clickable until the open animation finishes. Wait for them to be visible and use a JS click for the confirm button.
page/element click can be reported as not clickable under the modern headless Chrome, so the password-confirmation modal never opened; dispatch the click directly to trigger it reliably.
Three Chrome-149 issues stacked in this test: the queue toggle was clicked via its label span (which no longer reliably flips the checkbox), so the setting never changed; and the password-confirmation modal selectors were unscoped, so they matched a closed .confirm-password-modal instance instead of the open one. Click the checkbox input directly, JS-click the submit button, and scope all modal interactions to .modal.open. Verified locally: the redis connection error is now shown as expected.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the expected UI test screenshots for the new headless Chrome used by the modernized screenshot-testing harness (Node 24 / Puppeteer 24).
This is the submodule counterpart of the core migration PR and must be merged together with it:
matomo-org/matomo#24677
The screenshot changes are rendering drift from the new headless Chrome (identical content, minor line-height/anti-aliasing shifts); each was reviewed against the previous expected before syncing.
Checklist