Skip to content

Fix the parentIdTag key typo when ending a transaction with a different idTag - #458

Open
tzzee wants to merge 1 commit into
matth-x:mainfrom
tzzee:fix/parent-id-tag-key-typo
Open

tzzee wants to merge 1 commit into
matth-x:mainfrom
tzzee:fix/parent-id-tag-key-typo

Conversation

@tzzee

@tzzee tzzee commented Oct 2, 2026

Copy link
Copy Markdown

endTransaction() (OCPP 1.6) reads idTagInfo["parenIdTag"] after checking
containsKey("parentIdTag"). The misspelled key always yields null, so the
parentIdTag comparison never matches, and strcmp receives a null pointer
whenever the CSMS includes parentIdTag in the Authorize.conf.

This fixes the key and falls back to an empty string when the value is not a
string.

Introduced in f5cde7f (TC_069: Add support for ParentIdTag).

🤖 Generated with Claude Code

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant