Adds YuE2 support - #1539
Open
jtreminio wants to merge 2 commits into
Open
Conversation
jtreminio
commented
Sep 12, 2026
Comment on lines
+1019
to
+1020
| defsampler ??= "dpm_2"; | ||
| defscheduler ??= "sgm_uniform"; |
Contributor
Author
There was a problem hiding this comment.
honestly euler/normal is perfectly cromulent
jtreminio
commented
Sep 12, 2026
| ["style"] = UserInput.Get(T2IParamTypes.Text2AudioStyle, ""), | ||
| ["lyrics"] = prompt, | ||
| ["seed"] = UserInput.Get(T2IParamTypes.Seed, 0) + 10, | ||
| ["mode"] = "full", |
jtreminio
commented
Sep 12, 2026
Comment on lines
+2570
to
+2573
| if (!isPositive) | ||
| { | ||
| return FinalPrompt; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I noticed if you create duplicate YuE2GenerateABC/YuE2GenerateMusic and pipe to ConditioningZeroOut for the negative prompt, comfy helpfully duplicates the work it does, even when all params are identical.
Could have sworn identical nodes would be no-ops as their output would have been cached, but that wasn't the case here.
Member
There was a problem hiding this comment.
That's swarm side actually - Swarm's addnode will check for duplicates and just not add duplicate nodes - if you're getting actual multiple nodes in the final workflow, then they're not identical
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need guidance on how you want (if you want) to expose mode and max_abc_tokens
Model needs to go in Stable-Diffusion folder