Skip to content

Adds YuE2 support - #1539

Open
jtreminio wants to merge 2 commits into
mcmonkeyprojects:masterfrom
jtreminio:yue2-support
Open

Adds YuE2 support#1539
jtreminio wants to merge 2 commits into
mcmonkeyprojects:masterfrom
jtreminio:yue2-support

Conversation

@jtreminio

Copy link
Copy Markdown
Contributor

Need guidance on how you want (if you want) to expose mode and max_abc_tokens

Model needs to go in Stable-Diffusion folder

Comment on lines +1019 to +1020
defsampler ??= "dpm_2";
defscheduler ??= "sgm_uniform";

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly euler/normal is perfectly cromulent

["style"] = UserInput.Get(T2IParamTypes.Text2AudioStyle, ""),
["lyrics"] = prompt,
["seed"] = UserInput.Get(T2IParamTypes.Seed, 0) + 10,
["mode"] = "full",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full or melody

Comment on lines +2570 to +2573
if (!isPositive)
{
return FinalPrompt;
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed if you create duplicate YuE2GenerateABC/YuE2GenerateMusic and pipe to ConditioningZeroOut for the negative prompt, comfy helpfully duplicates the work it does, even when all params are identical.

Could have sworn identical nodes would be no-ops as their output would have been cached, but that wasn't the case here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's swarm side actually - Swarm's addnode will check for duplicates and just not add duplicate nodes - if you're getting actual multiple nodes in the final workflow, then they're not identical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants