The package std module takes the prebuilt C library's tokens, and an unset iOS floor is the located SDK's version (2026.9.14.1) - #633
Merged
Conversation
…unset iOS floor is the located SDK's version (2026.9.14.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two engine gaps that
mcpplibs/libcxx's CI surfaced once it measured every row the package claims (#630 follow-up).The package std module lacked the prebuilt C library. A package that supplies the C++ layer over a prebuilt C library (
llvm.libcxxover glibc, or over an Apple SDK) cannot name that library's headers, and the target-side broadcast carries only graph layers. The precompile therefore read whatever the driver found: on Linux the runner's/usr/includerather than the payload's glibc, which no report showed; on macOS nothing, and it stopped onmbstate_t. The command now takes the same tokens every translation unit gets (host_compile_tokens, with the C++ layer marked as the graph's), appended after the package's own directories so that libc++'s headers keep precedence over the C library's. e2e 663 asserts the recorded command names the glibc payload.An unset
ios_deployment_targetwas an unversioned triple.docs/20promised the SDK's default; clang's default forarm64-apple-ioswith no version is older than any SDK on the machine and refuses thread-local storage, which libc++abi uses. The located SDK's version (xcrun --sdk <name> --show-sdk-version) now fills the slot when the manifest states none;ci-macos-ios's plain fixture drops its floor and assertsLC_BUILD_VERSION minosequals the SDK's version. Docs in both languages restated.