Skip to content

release canaries: a project's commands do not see XLINGS_BIN #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sunrisepeak merged 1 commit into from
Oct 11, 2026
Merged

release canaries: a project's commands do not see XLINGS_BIN #799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/release-canaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,13 @@ jobs:
run: |
export MCPP="$CANDIDATE"
export MCPP_VENDORED_XLINGS="$XLINGS_BIN"
# The project's commands do not see the name: mcpp has its xlings
# above, and a project may give XLINGS_BIN its own meaning. xlings'
# test kit reads it as the binary under test, so its tests drove the
# released xlings instead of the one they had just built (2026.10.11.1:
# test_subos_new_template read an instance.json the released xlings
# does not write).
unset XLINGS_BIN
# The bash running this step, by path (release_canaries.py says why).
if [ "$RUNNER_OS" = Windows ]; then
export CANARY_BASH="$(cygpath -w "$BASH")"
Expand Down
Loading