Repository navigation
0.16.9 --- the ok image exports __cxa_thread_atexit; openkal-musl 0.22.9 - #48
Merged
Merged
Conversation
Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An ok image holding a
thread_localwith a destructor was refused byokld check:__cxa_thread_atexitwas exported on Linux, Fuchsia, PE and Mach-O only, and an ok image's triple (<arch>-unknown-none-elf) is none of them (found building clangd as an ok image, Sunrisepeak/mcppls-clangd#11).mcpp.toml:cfg(os = "openkal")statesOPENKAL_TARGET_IMAGE, ascfg(windows)statesOPENKAL_TARGET_WINDOWS.cxa_thread_atexit.cpp: the guard includes the ok image, which registers directly (no weak probe; an image imports onlykal_*).examples/image-cxx: athread_localwith a destructor, run on the four hosts. Without the fix the image is not sealed (okld: imports '__cxa_thread_atexit'); with it the destructor runs.Co-authored-by: speak-agent 248744407+speak-agent@users.noreply.github.com