Add skipCreation to document updates - #993
Ishubhammohole wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe SDK adds ChangesskipCreation document operations
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant Client
participant Index
participant Documents
participant Meilisearch
Client->>Index: Call addDocuments or updateDocuments with skipCreation
Index->>Documents: Forward document data and skipCreation
Documents->>Meilisearch: Send POST or PUT request with skipCreation
Meilisearch-->>Documents: Return task response
Documents-->>Index: Return TaskInfo
Index-->>Client: Return TaskInfo
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Added Javadocs for both request helpers and all five regression-test lifecycle/test methods, covering the missing documentation in this diff. Java 17: ./gradlew spotlessApply test --tests com.meilisearch.sdk.DocumentsSkipCreationTest javadoc spotlessCheck -x jacocoTestReport -x jacocoTestCoverageVerification --no-daemon passed (3 focused tests). Docker Compose could not run because the Docker daemon is unavailable. The full local test run had 3 existing SettingsHandlerTest failures (integration-style tests requiring a Meilisearch instance); an initial Java 21 attempt also encountered the existing Byte Buddy version limitation. This follow-up only changes comments and was prepared with Codex assistance. |
Summary
skipCreationoverloads for add/replace and add/update document callsskipCreationquery parameter while preserving existing request URLsTesting
./gradlew test --tests com.meilisearch.sdk.DocumentsSkipCreationTest -x jacocoTestCoverageVerification— passed (3 tests)./gradlew spotlessCheck— passedbash ./scripts/lint.sh— passeddocker compose run --rm -v gradle-cache:/root/.gradle package ./gradlew test— 115/116 passed;SettingsHandlerTestdictionary reset timed outdocker compose run --rm -v gradle-cache:/root/.gradle package ./gradlew test --tests com.meilisearch.sdk.SettingsHandlerTest -x jacocoTestCoverageVerification— passed on immediate rerun (3 tests), confirming the timeout was transientAI-assisted development was used to inspect the existing overload and URL-building patterns, implement the scoped change, and draft focused tests. The final diff and test results were reviewed before submission.
Fixes #919
Summary by CodeRabbit
New Features
Documentation