ci: remove the scheduled link-check issue caller - #131
Merged
Merged
Conversation
Owner decision 2026-09-14: no automated process should open GitHub issues on its own. link-check.yml only ever produced a rolling tracking issue from the ci-workflows reusable link-check workflow, so delete the caller and its stale references. Refs: melodic-software/.github Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019mo9xaZ53JHHy4aBjgd8wK
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kyle-sexton
added a commit
to melodic-software/claude-code-plugins
that referenced
this pull request
Sep 14, 2026
No linked issue ## Summary Owner decision 2026-09-14: remove every automated process that opens GitHub issues on its own. `link-check.yml` was the only local caller of the ci-workflows reusable `link-check.yml`, whose sole output is a rolling tracking issue filed on failure. ## Fix - Deleted `.github/workflows/link-check.yml` (the scheduled caller). - Removed the now-dead file entry from `.github/workflows/ci.yml`'s workflow-schema validation list and dropped the stale `link-check.yml` comparisons in `.github/workflows/silent-revert-canary.yml` and `.github/workflows/video-digest-source-liveness.yml`. - Updated `docs/architecture/landscape.json` and `docs/architecture/landscape.md` to match `reference-edges.sh`'s actual output for the `ci-workflows` uses-workflow edge (count 23 across 5 files, including `managed-files-guard.yml`, which had fallen out of the row's 5-file cap behind `link-check.yml`). - Recorded the lane's removal in `docs/specs/provenance-convention-engagement.md` (the dead-pointer round-trip wiring this repo's weekly lane fed is now dormant here). - `.github/runner-policy.json` (local) has no `exceptions` entries, so there was no job grant to remove there. - Left `.github/standards/runner-policy/policy.json` untouched per scope (`.github/standards/**` is off-limits to this PR). It still carries several `melodic-software/ci-workflows/.github/workflows/link-check.yml@<sha>` grants, including the pinned SHA the deleted caller used; those are now orphaned and worth pruning in a standards-owned change. - Left `lychee.toml` untouched: it's SYNC-MANAGED (the `lychee` component in `melodic-software/standards`'s `distribution/sync-manifest.yml`, guarded by `managed-files-guard.yml`). Its "the online advisory lane reuses this file" comment is now stale fleet-wide under the same owner decision and needs a standards-repo change, not a local edit. - Left `issue-triage-label.yml` untouched, and left the generic "link-check lane" prose in `docs/specs/provenance-design-threads.md`, `docs/specs/provenance-capability-matrix.md`, `plugins/provenance/**`, `plugins/docs-hygiene/**`, `docs/conventions/standards/README.md`, `plugins/planning/reference/standards-contract.md`, and `plugins/review/reference/standards-contract.md` alone — those describe the general convention/lane pattern and the plugin-vs-consuming-repo ownership boundary, not an enumeration of this specific caller file. ## Verification - `git diff --stat` across both commits: `.github/workflows/link-check.yml` deleted, plus targeted edits to 7 other files. - `npm ci` completed successfully in the worktree before committing. - Grepped the repository for `link-check` (case-insensitive) and reviewed every hit. - Ran `plugins/architecture/skills/map-landscape/scripts/reference-edges.sh . --owner melodic-software` to verify the corrected landscape edge matches ground truth exactly. - CI green on the final commit (`ci-status`, `ci-lanes`, and all other required checks passing); one `hook-utils` failure on the first push was a pre-existing flake (two `begin:` FILE_DIR/FILE_BASE assertions unrelated to this diff) confirmed by a clean rerun. - Both Codex review threads addressed and resolved. ## Related - Refs melodic-software/.github#131 (companion PR removing the same caller in the `.github` repo) --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No related issue: owner decision 2026-09-14 to remove every automated process that opens GitHub issues on its own; this is org-wide cleanup, not a tracked bug or feature.
Summary
link-check.ymlwas the last local caller of the ci-workflows reusablelink-check.yml, whose sole output is a rolling tracking issue filed on failure.Fix
.github/workflows/link-check.yml(the scheduled caller).README.md's CI description to drop the paragraph describinglink-check.ymlas "the one remaining caller of a ci-workflows reusable workflow" and the now-moot note about that reusable-workflow pin's update path (Dependabot only tracks composite-action pins, not reusable-workflow pins, and this repo no longer has any reusable-workflow caller)..github/runner-policy.jsonand no.github/standards/**tree, so there was no job grant or standards-owned file to touch..github/dependabot.ymlalone; it never pinned the reusable-workflow ref.lychee.tomluntouched: it's SYNC-MANAGED (thelycheecomponent inmelodic-software/standards'sdistribution/sync-manifest.yml). Its "the online advisory lane reuses this file" comment is now stale fleet-wide (this repo andclaude-code-plugins, companion PR ci: remove the scheduled link-check issue caller claude-code-plugins#4166, both lost their sole online caller under the same owner decision) and needs a standards-repo change, not a local edit here.Verification
git diff --staton the commit: 2 files changed, 2 insertions(+), 39 deletions(-), includingdelete mode 100644 .github/workflows/link-check.yml.link-check(case-insensitive); the only remaining hit islychee.toml's generic "link-checking config" comment, which does not name this workflow and still applies to the offline lychee lane inci.yml.ci-statusand every other check passing on the head commit.Related
claude-code-pluginsrepo)