fix(pr-template): name one no-issue escape and require its reason - #135
Merged
Merged
Conversation
The top-of-template guidance told the author to write `No related issue: <reason>`; the `## Related` comment told them to state `No linked issue`, in backticks, with no reason. The `pr-contract` composite masks inline code spans before matching, so the backticked form is invisible to the linkage check: the PR draws the advisory `needs-issue-linkage` label with nothing on screen to explain why. Keep one escape, on the top line, written as plain text, with the reason required and the backtick trap named. The `## Related` comment now points at that line instead of offering a second form. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M98vWnd3jQJ19Pe6Uj7bV9
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No related issue: this fixes the org PR template itself and closes nothing; the program it belongs to is referenced, not closed, under Related.
Summary
Nine of the thirteen enrolled repositories inherit this template through
GitHub's default community-health-file fallback, two of them since they
deleted their local copies earlier today (claude-code-plugins#4177,
provisioning#453). The template gave the author two different no-issue
escapes: the top-of-template guidance said to write
No related issue: <reason>, while the## Relatedcomment said to stateNo linked issue, in backticks, with no reason.The
pr-contractcomposite that runs insideci-statusmasks inline codespans before matching the body, so an author who copied the second form
literally failed the linkage check and drew the advisory
needs-issue-linkagelabel with nothing on screen to explain why.Fix
One escape, in one place. The top-of-template guidance now shows
No related issue: <reason>on its own line as plain text, states that thereason is required, and names the backtick trap. The
## Relatedcommentstops offering a second form: it says the section must not be empty and
points at the top line for the no-issue case.
The wording comes from what the gate accepts and from
.claude/rules/pr-body-contract.md, the convention's home, which alreadyspecifies the literal
No related issue: <reason>.melodic-software/standardscarries the matching change to the lockstepexpectation and must merge first, or its
pr-convention-locksteplane turnsred on this template.
Verification
The composite's own
analyze_bodyanalyzer, extracted fromrun.shat2c1de45aa0e1b1489afb8edfebc12cb3a4fa6ac3(v0.24.0, the SHA this repositorypins), run over four bodies with all four contract sections filled. A body
passes linkage only if the analyzer emits
closing,non-closing, orno-issue.no-issue## Relatedform verbatim, backtickedno-issueno-issueThe revised template, untouched, still reports all four sections empty and
emits no
no-issuesignal, so it cannot pass vacuously. This PR body uses thenew escape wording verbatim, so the
pr-contractstep on this PR is thedemonstration.
node .github/scripts/pr-section-drift.test.mjspasses and the livepr-section-drift.mjsrun matches the pinned composite; the headings areunchanged.
markdownlint-cli2reports 0 issues.Related
Refs: melodic-software/github-iac#378
🤖 Generated with Claude Code
https://claude.ai/code/session_01M98vWnd3jQJ19Pe6Uj7bV9