ci: converge ci-workflows references on v0.24.0 - #4180
Merged
Merged
Conversation
Move the 22 remaining `melodic-software/ci-workflows` references to `2c1de45aa0e1b1489afb8edfebc12cb3a4fa6ac3` (v0.24.0), the single target SHA the program converges every consumer repository onto. Nineteen are composite actions in `ci.yml`; the other three are the reusable workflows called by `claude-review.yml`, `claude-security-review.yml` and `issue-triage-label.yml`. Every `# vX.Y.Z` comment moves with its pin, so each now reads `# v0.24.0`. `managed-files-guard.yml` was already at the target and is untouched, which leaves all 23 references on one SHA. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M98vWnd3jQJ19Pe6Uj7bV9
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This repository converges its
melodic-software/ci-workflowsreferences on theprogram's single target SHA
2c1de45aa0e1b1489afb8edfebc12cb3a4fa6ac3(v0.24.0). It is the last consumer repository still carrying v0.22.2 pins; every
other consumer is already there. Twenty-two references move, and with
managed-files-guard.ymlalready at the target, all twenty-three references inthe repository now sit on one SHA.
Fix
Nineteen of the twenty-two are composite actions in
.github/workflows/ci.yml:change-detection,markdown,typos,gitleaks,editorconfig,shellcheck(twice),actionlint,check-jsonschema(five call sites),exec-bit,machine-specific-paths,eol-renormalize,comment-hygiene,pr-contractandci-status. The other three are reusable workflows:claude-review.yml,claude-security-review.ymlandissue-triage-label.yml.Every
# vX.Y.Zcomment moves with the pin it annotates, so each of thetwenty-two now reads
# v0.24.0. Nothing in this repository checks that aversion comment resolves to the SHA beside it, so the comment is only as good as
the change that writes it; the pin and the comment were replaced as one string,
which makes a mismatch structurally impossible rather than merely unobserved.
No input, secret or permission this repository passes changed. Between v0.22.2
and v0.24.0 the only edits to the paths consumed here are the
ci-statuscomposite's input documentation (the sizing guidance for
carry-forward-wait-seconds, whose name and240default are unchanged) and theinner
anthropics/claude-code-actionpin inside the two Claude reusables(v1.0.215 to v1.0.216). The remaining ci-workflows edits in that range are to
scripts and paths this repository does not call, or to workflows it never
referenced.
issue-triage-label.ymlmoves for the first time here: it was held back onv0.22.2 because the standards-managed runner policy carried no reviewed contract
for it at the new pin. melodic-software/standards#571 registered that contract,
and the sync landed it in this repository's
.github/standards/runner-policy/policy.jsonin #4179, which merged before thisbranch was cut. This branch does not touch
.github/standards/**.Verification
Run from the branch worktree at head
547d43bc:node .github/standards/runner-policy/runner-policy.mjs --root .(afternpm ci --prefix .github/standards/runner-policy) printsRunner policy passed., exit 0. The check is not vacuous: replacing theissue-triage-label.ymlpin with an unregistered SHA makes it exit 1, namingthe reusable workflow and reporting that its
path@SHAhas no reviewedrunner-input contract. The branch was restored to its committed state
afterwards.
actionlint -config-file .github/actionlint.yaml .github/workflows/*.yml—exit 0, no output.
bash scripts/check-lane-coverage.test.sh—PASS=40 FAIL=0.bash scripts/check-lane-coverage.sh --check— all 4 lanes reachable fromci-status.needs; all 60 gate steps fed to the aggregator, 2 opted out.bash scripts/check-docs-only-gate.sh --check— scope resolved once inchanges; 130 references across 4 consumer jobs, all in the sanctioned form.python scripts/check-manifest-duplicate-keys.py— no duplicate keys in 78manifests.
The target SHA is the tag:
git tag --points-at 2c1de45aa0e1b1489afb8edfebc12cb3a4fa6ac3in the ci-workflows clone returns
v0.24.0, and nothing else.Counts, on the branch: zero occurrences of
5776760254f8b63cba44e896f51604cb755350d9anywhere under
.github/workflows/, and twenty-three of@2c1de45aa0e1b1489afb8edfebc12cb3a4fa6ac3 # v0.24.0. The diff is 22 insertionsand 22 deletions across the four files, and every changed line is a
melodic-software/ci-workflowsreference.Three occurrences of the old SHA remain in the tree and are deliberately left
alone:
plugins/source-control/hooks/pr-body-linkage-gate.test.sh,pr-linkage-mcp-gate.test.shandpr-linkage-spawn-budget.test.sheach embed asynthetic
jobs.ci-status.stepsfragment in aprintfstring, written into atemp directory as a fixture. The hooks under test key on the presence of a
pr-contract@step, never on the SHA, so those strings are fixture data and notpins; bumping them would widen the diff without changing what is exercised. The
truncated
5776760…in.claude/unhobble/**is a historical evidence record ofwhat was true when it was written.
Related
Refs: melodic-software/github-iac#378
Refs: melodic-software/standards#571
🤖 Generated with Claude Code
https://claude.ai/code/session_01M98vWnd3jQJ19Pe6Uj7bV9