ci: converge ci-workflows composite pins on v0.24.0 - #48
Merged
Merged
Conversation
`ci.yml` pinned the `pr-contract` and `ci-status` composites at 541ee4e (v0.23.0) while `managed-files-guard.yml` already resolved v0.24.0, so this repository referenced ci-workflows at two commits. Both composite references now resolve to one commit, 2c1de45 (v0.24.0), with the pin comments moved alongside the SHAs. No behaviour change: `git diff v0.23.0 v0.24.0` is empty for both `.github/actions/pr-contract/` and `.github/actions/ci-status/`, and every `with:` key at both call sites (`token`; `results`, `treat-skipped-as`, `carry-forward-wait-seconds`, `token`) is a declared input at v0.24.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M98vWnd3jQJ19Pe6Uj7bV9
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No related issue: fleet-wide pin convergence sweep; the tracking issue lives in melodic-software/github-iac and is referenced below rather than closed by this repository's slice.
Summary
This repository referenced
melodic-software/ci-workflowsat two differentcommits.
.github/workflows/ci.ymlpinned thepr-contractandci-statuscomposites at
541ee4e(v0.23.0), while.github/workflows/managed-files-guard.ymlalready resolved
2c1de45(v0.24.0). The "two halves" pin rule forci-workflowsrequires every composite reference in a repository to resolve toONE commit, so the split had to close.
Fix
Both composite references in
.github/workflows/ci.ymlnow resolve to2c1de45aa0e1b1489afb8edfebc12cb3a4fa6ac3(v0.24.0), with the pin comment movedalongside each SHA. Two lines, one file.
managed-files-guard.ymlisSYNC-MANAGEDand was already on target; it isuntouched.
.github/dependabot.ymlmentionsci-workflowsonly in a prosecomment about grouped updates, carries no SHA, and is untouched.
The reusable-workflow half of the rule imposes nothing here: this repository has
no
.github/standards/tree, sorunner-policydoes not govern it, and itreferences no
ci-workflowsreusable workflow — both off-target references werecomposites.
Verification
git diff v0.23.0 v0.24.0 -- .github/actions/pr-contract/ .github/actions/ci-status/in the
ci-workflowsclone is EMPTY. Neither composite changed between the twotags, so this is a pin move with no behaviour change.
with:key at both call sites is a declared input of its composite'saction.ymlat2c1de45:tokenforpr-contract;results,treat-skipped-as,carry-forward-wait-secondsandtokenforci-status.resultsis the onlyrequired: trueinput and is supplied.541ee4e90d12d77a90a3ddd72a3af9bc78634ea7, forv0.23.0and forci-workflowsfinds no remaining live pin off target; theonly other hits are the already-converged
managed-files-guard.ymland prosecomments carrying no SHA.
actionlinton both workflowfiles (one pre-existing SC2016 info on the
linksjob, byte-identical onorigin/mainand untouched by this diff);shellcheckandbash -nonscripts/*.shand.cursor/install.sh;jq emptyon.cursor-plugin/marketplace.jsonand everyplugins/*/.cursor-plugin/plugin.json;the
SKILL.mdfrontmatter check; and the internal markdown link-integrity check.scripts/test-sync-local.shpasses 64 assertions; its 9 twin-parity assertionsfail on this Windows box only because the
pwshtwin emits nativeC:\...paths where the POSIX
<HOME>/...redaction expects forward slashes — anenvironment artifact of running a Linux CI lane locally, not a regression, and
unaffected by a change confined to
.github/workflows/ci.yml.upstream: the standards sync, the
managed-files-guardaction, and Dependabot.Stated plainly rather than claimed.
without access to this reasoning.
Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01M98vWnd3jQJ19Pe6Uj7bV9