[MOO-2463] : Background image native not rendering fix 11-6-x - #633
Open
saurabhchavan1711 wants to merge 3 commits into
Open
[MOO-2463] : Background image native not rendering fix 11-6-x#633saurabhchavan1711 wants to merge 3 commits into
saurabhchavan1711 wants to merge 3 commits into
Conversation
MxKevinBeqo
requested changes
Sep 9, 2026
| // When there's content, size container to content | ||
| const containerStyle = props.content | ||
| ? styles.container | ||
| : [styles.container, { flexGrow: 1, flexShrink: 1, flexBasis: "auto" as const }]; |
Contributor
There was a problem hiding this comment.
Let's consider switching the order of the styles in the array here, because now, if the user passes the same style props, they will be overwritten by our hard-coded ones.
And for extra points, we can create a const for the hard-coded style for better readability e.g.
const DEFAULT_CONT_STYLE = { flexGrow: 1 ....}
| @@ -121,7 +121,16 @@ exports[`BackgroundImage renders with default styles 1`] = ` | |||
|
|
|||
| exports[`BackgroundImage renders without content 1`] = ` | |||
Contributor
There was a problem hiding this comment.
Perhaps we can also add a snapshot test to address this scenario e.g. it("renders with visible dimensions without content", or it("fills available space when content is empty"...
|
|
||
| ## [Unreleased] | ||
|
|
||
| - Fixed background image widget not visible. |
Contributor
There was a problem hiding this comment.
We can also add here that the widget was not visible under specific scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅Feature specific
This PR contains
What is the purpose of this PR?
This PR fixes the background image native widget not rendering issue whenever there is no content in the background image native widget. Now with this change , if the content is there in image , it will work as before & if no content only i.e. background image , it will fill up to take the available space.